Skip to content

Conversation

@greenrobot-team
Copy link
Member

@greenrobot-team greenrobot-team commented Nov 9, 2021

#297

Add support for the replace conflict resolution strategy

  • to be used on at most one property,
  • if Sync is enabled all @Unique properties must use REPLACE strategy (and with above rule at most one can exist).

Tasks

  • Check if sync-enabled entity, all unique properties use REPLACE.
  • Add tests.
    • build_runner tests seem not possible (e.g. to verify errors on misconfigurations), so tested manually.

@greenrobot-team greenrobot-team force-pushed the unique-on-conflict-replace branch 3 times, most recently from dde2510 to ba008a1 Compare November 15, 2021 12:54
@greenrobot-team greenrobot-team force-pushed the unique-on-conflict-replace branch from ba008a1 to c9f5516 Compare November 15, 2021 13:11
@greenrobot-team greenrobot-team marked this pull request as ready for review November 15, 2021 13:11
Copy link
Member

@greenrobot greenrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@greenrobot-team greenrobot-team merged commit abc73ec into main Nov 16, 2021
@greenrobot-team greenrobot-team added this to the 1.3 milestone Nov 16, 2021
@greenrobot-team greenrobot-team deleted the unique-on-conflict-replace branch November 16, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants